Skip to content

Generate London cases for stTransactionTest/Opcodes_TransactionInit#839

Closed
gumb0 wants to merge 2 commits intoethereum:developfrom
ewasm:transaction-init-london
Closed

Generate London cases for stTransactionTest/Opcodes_TransactionInit#839
gumb0 wants to merge 2 commits intoethereum:developfrom
ewasm:transaction-init-london

Conversation

@gumb0
Copy link
Copy Markdown
Member

@gumb0 gumb0 commented May 10, 2021

This doesn't add any new cases, but generates London expectations for stTransactionTest/Opcodes_TransactionInit test using recent go-ethereum master.

It is supposed to help make changes in #835 smaller.

@gumb0 gumb0 force-pushed the transaction-init-london branch from 44d4210 to e635b63 Compare May 10, 2021 13:27
@gumb0 gumb0 requested review from qbzzt and winsvega May 10, 2021 13:52
@gumb0
Copy link
Copy Markdown
Member Author

gumb0 commented May 10, 2021

In discussion @winsvega he pointed out that he's going to regenerate all the tests to include London expectations at some point, probably after main EIPs for London (I guess at least EIP-1559) are merged into geth.

This PR can be closed then, if not useful.

@winsvega winsvega closed this May 10, 2021
@gumb0 gumb0 deleted the transaction-init-london branch May 11, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants