Skip to content

Constfix#582

Merged
winsvega merged 8 commits intodevelopfrom
constfix
Jan 24, 2019
Merged

Constfix#582
winsvega merged 8 commits intodevelopfrom
constfix

Conversation

@winsvega
Copy link
Copy Markdown

No description provided.

@holiman
Copy link
Copy Markdown
Contributor

holiman commented Jan 22, 2019

These tests seem to work for geth. See https://github.com/ethereum/go-ethereum/pull/18486/files#diff-15ce625a7afa9c3d8ea9ffc9b74a654aR49 . The only failing tests (as far as StateTests are concerned are

	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/Byzantium/0`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/Byzantium/3`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/Constantinople/0`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/Constantinople/3`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/ConstantinopleFix/0`, "bug in test")
	st.fails(`^stRevertTest/RevertPrecompiledTouch(_storage)?\.json/ConstantinopleFix/3`, "bug in test")

And those are cases of precompiles being touched and reverted and such things, which is not a mainnet issue.

Dimitry added 3 commits January 23, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants