-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce VM version ('hard fork') column for assembly opcodes #3604
Conversation
| Perhaps it would make sense retiring this as it equals to return(0,0). It can be an optimisation by the EVM | | ||
| backend. | | ||
+---------------------------------------------------------------------------------------------------------------+ | ||
| | Perhaps it would make sense retiring this as it equals to | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this comment come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was there. (This is the julia part.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but I still think this has no place in a documentation :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another PR which updates the builtins #3238, I'd just clean up these there and leave this single change as a formatting fix.
docs/assembly.rst
Outdated
@@ -153,6 +153,7 @@ If an opcode takes arguments (always from the top of the stack), they are given | |||
Note that the order of arguments can be seen to be reversed in non-functional style (explained below). | |||
Opcodes marked with ``-`` do not push an item onto the stack, those marked with ``*`` are | |||
special and all others push exactly one item onto the stack. | |||
Opcodes marked with ``H``, ``B`` or ``C`` are present since Homestead, Byzantium or Constantinople, respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the column has better visibility if we do not mark opcodes at all which are available even before homestead. We should also mention that constantinople is still in planning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, its only delegatecall
for homestead, everything else is frontier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated (also fixed revert
). Do we want to keep F
for frontier or remove it?
No description provided.