Enable parser to accept transient as data location or identifier
#15001
+474
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
requested review from
cameel,
r0qs,
ekpyron,
nikola-matic and
aarlt
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
from
7bea970
to
c0ec00e
Compare
nikola-matic
reviewed
Apr 8, 2024
...ns/externalFunction/function_argument_location_specifier_test_external_transient_storage.sol
Outdated
Show resolved
Hide resolved
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
3 times, most recently
from
0293833
to
5edd9de
Compare
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
from
6e15e6c
to
b0e31af
Compare
matheusaaguiar
commented
Apr 25, 2024
matheusaaguiar
commented
Apr 25, 2024
matheusaaguiar
commented
Apr 25, 2024
cameel
reviewed
Apr 26, 2024
cameel
reviewed
Apr 26, 2024
cameel
reviewed
Apr 26, 2024
test/libsolidity/syntaxTests/immutable/state_var_transient_data_location.sol
Outdated
Show resolved
Hide resolved
cameel
reviewed
Apr 26, 2024
test/libsolidity/syntaxTests/dataLocations/transient_function_type.sol
Outdated
Show resolved
Hide resolved
cameel
reviewed
Apr 26, 2024
test/libsolidity/syntaxTests/constants/constant_transient_state_variable.sol
Outdated
Show resolved
Hide resolved
cameel
reviewed
Apr 26, 2024
|
Just realized that it's also missing a changelog entry. Is it because it's considered experimental at this point? |
I guess I always forget about the changelog entry 😅 |
|
Well, it's actually a good question whether it should have an entry. The feature is not really usable to users in the current state so not much point advertising it. On the other hand we do include an entry when an experimental feature is introduced (just not when we change it), so maybe we should still have it. Also, it's not so much experimental as just incomplete... |
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
4 times, most recently
from
29e04e2
to
9064a16
Compare
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
from
511b702
to
41abbe5
Compare
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
from
41abbe5
to
ba5dbc9
Compare
matheusaaguiar
added
the
has dependencies
matheusaaguiar
changed the base branch from
develop
to
catchSolUnimplementedFeatureErrors
matheusaaguiar
force-pushed
the
catchSolUnimplementedFeatureErrors
branch
from
345b55e
to
2e99c16
Compare
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
from
6b6de54
to
9b325bb
Compare
cameel
reviewed
Jun 7, 2024
test/cmdlineTests/storage_layout_transient_value_types/output.json
Outdated
Show resolved
Hide resolved
test/cmdlineTests/storage_layout_transient_value_types/input.json
Outdated
Show resolved
Hide resolved
matheusaaguiar
force-pushed
the
catchSolUnimplementedFeatureErrors
branch
2 times, most recently
from
44750e3
to
a68961d
Compare
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
3 times, most recently
from
dec27f3
to
b83f470
Compare
cameel
reviewed
Jun 14, 2024
matheusaaguiar
force-pushed
the
catchSolUnimplementedFeatureErrors
branch
from
97c9383
to
bb16848
Compare
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
from
2da90a6
to
3eb5649
Compare
cameel
previously approved these changes
Jun 17, 2024
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
from
3eb5649
to
00af7ae
Compare
matheusaaguiar
commented
Jun 19, 2024
There was a problem hiding this comment.
@cameel , I was about to merge this but took a quick look before and found some details that could be improved. They were simple enough that I think we could quickly fix them before merging this finally.
test/libsolidity/syntaxTests/dataLocations/transient_reference_type_state_variables.sol
Outdated
Show resolved
Hide resolved
...ty/syntaxTests/dataLocations/variable_declaration_location_transient_test_reference_type.sol
Outdated
Show resolved
Hide resolved
cameel
approved these changes
Jun 20, 2024
matheusaaguiar
force-pushed
the
transientStorageParserHack
branch
from
76210d3
to
ad2644c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step on providing Solidity high-level support for transient storage.
closes #15006.
depends on #15121 (Merged).
depends on #15168.