Remove ROL/ROR as they are not part of EIP145 anymore

ethereum · Jan 5, 2018 · d9ec3e0 · d9ec3e0
1 parent bf22544
commit d9ec3e0
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 13 deletions.
diff --git a/docs/assembly.rst b/docs/assembly.rst
@@ -208,10 +208,6 @@ In the grammar, opcodes are represented as pre-defined identifiers.
 +-------------------------+------+-----------------------------------------------------------------+
 | sar(x, y)               |      | arithmetic shift right x by y                                   |
 +-------------------------+------+-----------------------------------------------------------------+
-| ror(x, y)               |      | rotate right x by y                                             |
-+-------------------------+------+-----------------------------------------------------------------+
-| rol(x, y)               |      | rotate left x by y                                              |
-+-------------------------+------+-----------------------------------------------------------------+
 | addmod(x, y, m)         |      | (x + y) % m with arbitrary precision arithmetics                |
 +-------------------------+------+-----------------------------------------------------------------+
 | mulmod(x, y, m)         |      | (x * y) % m with arbitrary precision arithmetics                |

diff --git a/libevmasm/Instruction.cpp b/libevmasm/Instruction.cpp
@@ -53,8 +53,6 @@ const std::map<std::string, Instruction> dev::solidity::c_instructions =
 	{ "SHL", Instruction::SHL },
 	{ "SHR", Instruction::SHR },
 	{ "SAR", Instruction::SAR },
-	{ "ROL", Instruction::ROL },
-	{ "ROR", Instruction::ROR },
 	{ "ADDMOD", Instruction::ADDMOD },
 	{ "MULMOD", Instruction::MULMOD },
 	{ "SIGNEXTEND", Instruction::SIGNEXTEND },
@@ -198,8 +196,6 @@ static const std::map<Instruction, InstructionInfo> c_instructionInfo =
 	{ Instruction::SHL,		{ "SHL",			0, 2, 1, false, Tier::VeryLow } },
 	{ Instruction::SHR,		{ "SHR",			0, 2, 1, false, Tier::VeryLow } },
 	{ Instruction::SAR,		{ "SAR",			0, 2, 1, false, Tier::VeryLow } },
-	{ Instruction::ROL,		{ "ROL",			0, 2, 1, false, Tier::VeryLow } },
-	{ Instruction::ROR,		{ "ROR",			0, 2, 1, false, Tier::VeryLow } },
 	{ Instruction::ADDMOD,		{ "ADDMOD",			0, 3, 1, false, Tier::Mid } },
 	{ Instruction::MULMOD,		{ "MULMOD",			0, 3, 1, false, Tier::Mid } },
 	{ Instruction::SIGNEXTEND,	{ "SIGNEXTEND",		0, 2, 1, false, Tier::Low } },

diff --git a/libevmasm/Instruction.h b/libevmasm/Instruction.h
@@ -64,8 +64,6 @@ enum class Instruction: uint8_t
 	SHL,				///< bitwise SHL operation
 	SHR,				///< bitwise SHR operation
 	SAR,				///< bitwise SAR operation
-	ROL,				///< bitwise ROL operation
-	ROR,				///< bitwise ROR operation
 
 	KECCAK256 = 0x20,		///< compute KECCAK-256 hash
 

diff --git a/libsolidity/inlineasm/AsmAnalysis.cpp b/libsolidity/inlineasm/AsmAnalysis.cpp
@@ -537,9 +537,7 @@ void AsmAnalyzer::warnOnInstructions(solidity::Instruction _instr, SourceLocatio
 	static set<solidity::Instruction> experimentalInstructions{
 		solidity::Instruction::SHL,
 		solidity::Instruction::SHR,
-		solidity::Instruction::SAR,
-		solidity::Instruction::ROL,
-		solidity::Instruction::ROR
+		solidity::Instruction::SAR
 	};
 	if (experimentalInstructions.count(_instr))
 		m_errorReporter.warning(