Replaces yargs with commander. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is worth noting, I'm leaning on existing tests covering this. I did do a run of |
|
Looking into test failures now (the tests won't run on my machine for some reason): |
MicahZoltu
force-pushed
the
yargs-replacement
branch
from
dbcc938
to
4cd0a42
Compare
axic
reviewed
Oct 28, 2019
solcjs
Outdated
| .option('--optimize', 'Enable bytecode optimizer.') | ||
| .option('--bin', 'Binary of the contracts in hex.') | ||
| .option('--abi', 'ABI of the contracts.') | ||
| .option('--standard-json', 'Standard JSON configuration file.') |
There was a problem hiding this comment.
This doesn't take a file name so that the help text is confusing. I'd suggest to stick to the original text.
There was a problem hiding this comment.
Oops, I have no idea why I changed that. Fixed.
There was a problem hiding this comment.
Ugh, I pushed the wrong branch... give me a few minutes while I clean up the mess I just created for myself.
Works towards resolving ethereum#361. Yargs brings in ~26 packages while commander brings in 1.
MicahZoltu
force-pushed
the
yargs-replacement
branch
from
4cd0a42
to
d268ffa
Compare
axic
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards resolving #361. Yargs brings in ~26 packages while commander brings in 1.