This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Add sendCompilationResults API capability to remix-lib #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2018
yann300
reviewed
Sep 19, 2018
| @@ -177,6 +177,19 @@ function Compiler (handleImportCall) { | |||
| return null | |||
| } | |||
|
|
|||
| this.ldCompilationResult = (file, source, languageVersion, data) => { | |||
There was a problem hiding this comment.
@yann300 I think this might be still needed and necessary to actually change the compiler's lastCompilationResult, or else we might be missing a handler to set that state variable for the rest of Remix. Please let me know what you think!
There was a problem hiding this comment.
@yann300 Oh were you referring to the log statements? removing those now
oogetyboogety
force-pushed
the
master
branch
from
5d3d39b to
da2052a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ethereum/remix-ide#1521
Accepts any language's output from a compiler that follows the solc JSON API https://solidity.readthedocs.io/en/v0.4.24/using-the-compiler.html