optional logo in quick-dapp #5306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
yann300
reviewed
Oct 29, 2024
|
The logo for uploading a logo is too large: It also does not say that it is optional. The design if the widget should be closer to the wireframe - in that there should be a title - Logo, some instructions and an upload button. Just the upload logo is not enough information and it dominates the page - which it should not. The size of the logo in the deployed dapp is 95px x 95px. This should be stated in the instructions. |
LianaHus
requested changes
Nov 4, 2024
|
closing as #5376 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5291