Conversation
|
This is just going to track my progress. I'm developing this concurrently with this branch in the ethereum-tester library: ethereum/eth-tester#14 |
pipermerriam
force-pushed
the
piper/implement-mainnet-tester
branch
5 times, most recently
from
a3aa9cb to
51e7faf
Compare
pipermerriam
force-pushed
the
piper/implement-mainnet-tester
branch
from
51e7faf to
8b76f13
Compare
pipermerriam
changed the title
evm/vm/flavors/tester/__init__.py
Outdated
| parent_header, | ||
| **assoc(header_params, 'gas_limit', parent_header.gas_limit) | ||
| ) | ||
| return create_tester_header_from_parent |
There was a problem hiding this comment.
Wouldn't it make more sense to wrap it with classmethod() here?
evm/vm/flavors/tester/__init__.py
Outdated
| Creates and initializes a new block header from the provided | ||
| `parent_header`. | ||
| """ | ||
| return parent_class.create_header_from_parent( |
There was a problem hiding this comment.
I don't understand why we want to ignore the class on which the method was called (vm_class) and instead always use parent_class? Maybe it deserves a comment?
evm/vm/flavors/tester/__init__.py
Outdated
|
|
||
|
|
||
| @reversed_return | ||
| def _generate_vm_configuration(homestead=None, dao=None, anti_dos=None): |
There was a problem hiding this comment.
It took me a while to realize what values the arguments here could take. Maybe add a _start_block suffix to them, or a docstring?
evm/vm/flavors/tester/__init__.py
Outdated
| """ | ||
| pass | ||
|
|
||
| def configure_forks(self, homestead=None, dao=None, anti_dos=0): |
There was a problem hiding this comment.
Same here about the args names
|
@gsalgado I believe I've addressed all of your comments. Merging when green unless I hear otherwise. |
evm/vm/flavors/tester/__init__.py
Outdated
|
|
||
| class MaintainGasLimitMixin(object): | ||
| @classmethod | ||
| def create_tester_header_from_parent(cls, parent_header, **header_params): |
There was a problem hiding this comment.
Shouldn't this be create_header_from_parent?
|
fixing test failure here: https://github.com/pipermerriam/py-evm/pull/105 |
minor formatting updates, remove additional docs to separate pr
2 participants
Blocker for: ethereum/eth-tester#14
What was wrong?
Py-EVM needs a tester chain that can be used with testing. Primary features needed are:
How was it fixed?
Added a new
Chainsubclass underevm.vm.flavors.testerwith these properties.Cute Animal Picture