Issue #1942 remove linting error ignores

[Elnaril]

What was wrong?

PR #1940 added the flake8 error code E252 to be ignored, which was a temporary solution to wait until all these errors were fixed in the codebase.

How was it fixed?

• E252 has been removed from the ignore section of flake8 in tox.ini
• All errors raised by tox were fixed by adding a space around operators where missing

To-Do

• Clean up commit history

• Add entry to the release notes

Cute Animal Picture

[Elnaril]

Hello @pipermerriam , @carver , @cburgdorf , @gsalgado , I'm not sure who I should ask for a review so I picked up the top 4 contributors ! 😅 😄 Would it be possible to have this PR reviewed ? 🙏

[carver]

Yup, looks great, thanks for the contribution!

Would you mind stripping out the W503 also? While you're working on that, it seems that the two commits can be squashed too. But if you prefer, I'm happy to squash-merge it for you after the W503 change.

[carver]

W503 was only here because of E252, so we can actually delete the W503 ignore now, also.

[Elnaril]

@carver thanks for the review ! :-)

W503 was only here because of E252, so we can actually delete the W503 ignore now, also.

Actually I tried it but I'm not sure that's possible because when I comment out this flag:

flake8 gets grumpy:

and if I add the line break after the operator, from:

to:

I get the W504:

[carver]

Interesting! I wonder if the commented out lines look to flake8 like an empty list that overrides the default list, which causes the same problem as adding E252. Anyway, no need to hunt that down right now. I'll just squash-merge unless you prefer to squash it yourself.

[Elnaril]

Yep, I agree the behaviour seems weird ...

I'll just squash-merge unless you prefer to squash it yourself.

That's all good to me if you do it, thanks ! :-)

[Elnaril]

Actually, you may be right about the comment (or empty include) confusing flake8:

with that:

the linting is ok:

but with that:

the errors are back ...

[Elnaril]

Shall I remove the include= and commit ?

[carver]

Hm, seems like that confusing error will just come back the next time someone wants to include an exception.

[carver]

Maybe change the comment like:

- W503 gets enabled when E252 gets ignored, see:
+ W503 gets enabled when any "ignore =" config is added (even the empty one), see:

and then I'll squash-merge.

[Elnaril]

Change is done