This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Emit better balance diffs when comparing accounts#1580
Merged
carver merged 1 commit intoethereum:masterfrom Dec 12, 2018
Merged
Emit better balance diffs when comparing accounts#1580carver merged 1 commit intoethereum:masterfrom
carver merged 1 commit intoethereum:masterfrom
Conversation
Instead of emitting expected - actual, emit actual - expected. Rationale (by @veox): > For example, as things stand, if a fixture-expected value is 1000, and > the actual produced by py-evm is 500, the printed message will show a > delta of 500 - that is, a net positive, whereas what truly happened is > py-evm having produced a value that's too low. This is confusing: say, a > miner's account balance showing "Delta: 500" makes one think that the > miner received 500 wei more than expected (which is not true). Reference: - ethereum#1181 (comment) - ethereum#1573 (comment)
pipermerriam
approved these changes
Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of emitting expected - actual, emit actual - expected.
Rationale (by @veox):
Reference:
Cute Animal Picture