This repository was archived by the owner on Sep 8, 2025. It is now read-only.
API docs + some fine tuning for Plugin API#1424
Merged
cburgdorf merged 4 commits intoethereum:masterfrom Oct 25, 2018
Merged
Conversation
cburgdorf
force-pushed
the
christoph/docs/plugins
branch
2 times, most recently
from
b6ebfda to
a4fb07c
Compare
| chain: | ||
| --data-dir DATA_DIR The directory where chain data is stored | ||
| --nodekey NODEKEY Hexadecimal encoded private key to use for the nodekey | ||
| --nodekey-path NODEKEY_PATH |
Member
There was a problem hiding this comment.
side note: we should be able to merge the functionality of this argument in with the --nodekey argument and just do detection on whether the arg is referencing a file or that it's just a string nodekey.
| Extensibility | ||
| ============= | ||
|
|
||
| .. note:: |
| Describe the name of the plugin | ||
| Describe the name of the plugin. | ||
| """ | ||
| raise NotImplementedError( |
Member
There was a problem hiding this comment.
you could replace this NotImplementedError with a pass (our current convention).
cburgdorf
force-pushed
the
christoph/docs/plugins
branch
3 times, most recently
from
b28d04e to
9a8b639
Compare
cburgdorf
force-pushed
the
christoph/docs/plugins
branch
from
9a8b639 to
9389ab0
Compare
cburgdorf
changed the title
Contributor
Author
|
@pipermerriam I decided to spin out the guide into a separate PR (#1429) as writing the guide will still take a bit more time and I think we can get this in independently from the guide. |
Closed
pipermerriam
approved these changes
Oct 25, 2018
Member
pipermerriam
left a comment
pipermerriam
left a comment
There was a problem hiding this comment.
👍 but a bit of a rubber stamp. Didn't 👀 all of the docstrings carefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Plugins didn't have proper API docs yet. There were also some easy to fix glitches that this PR addresses. Notice that this is just a first step towards a full detailed plugin guide which is coming in a separate PR (#1429 )
How was it fixed?
TrinityBootInfotype to reduce complexity of several method signaturespassinstead ofraisefor abstract methodsNoneas a contextCute Animal Picture