Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF Implementers Call #49 #1055

Closed
poojaranjan opened this issue May 31, 2024 · 8 comments
Closed

EOF Implementers Call #49 #1055

poojaranjan opened this issue May 31, 2024 · 8 comments

Comments

@poojaranjan
Copy link
Contributor

poojaranjan commented May 31, 2024

Meeting Info

June 05, 2024 , 15:00 UTC

Duration: 60 minutes

Zoom: https://us02web.zoom.us/j/88940506383?pwd=aTdsbHVyMTNDSUFHYmhTWlI2ZEVldz09

📅 Subscribe to the Ethereum Protocol Call calendar for calendar invites

Resources

Agenda

Please add other agenda items or links to discuss.

@chfast
Copy link
Member

chfast commented Jun 5, 2024

Code size limits for tests: are we forcing current limit of 24k/48k? Some tests already exercise the 64k limit.

@shemnon
Copy link
Contributor

shemnon commented Jun 5, 2024

Add to spec updates - ipsilon/eof#124 - EXTDELEGATECALL clarified to fail when calling non-eof, (as opposed to actual legacy contracts)

@shemnon
Copy link
Contributor

shemnon commented Jun 5, 2024

Re 24k/48k/64k it's a question of where we enforce it.

For returncontract do we enforce it in the opcode or let the storage system tell us no-bueno?

For EOFCREATE in theory the Create Transaction should have filtered it pre-execution, and factory contracts are already size limited to runtime sizes. A TXCREATE opcode would need to check, but again the transaction processor should have filtered it out?

@gumb0
Copy link
Member

gumb0 commented Jun 5, 2024

Proposal to ban subcontainers that only REVERT/INVALID and can be referenced by both EOFCREATE and RETURNCONTRACT. Two options:

  1. Require each subcontainer to have STOP or RETURN or RETURNCONTRACT.
  2. Disallow EOFCREATE and RETURNCONTRACT referencing the same container.

(option 2 would still allow containers that only have REVERT)

@poojaranjan
Copy link
Contributor Author

Notes (by @pdobacz )

client updates:

geth

  • ~60/1000 tests failing, making progress

evmone

  • merged RETURNDATACOPY oob, Creation TX, ASE EXT*CALL, initcode mode validation in progress

besu

  • progress on testing support

compiler updates

None

spec updates:

testing updates:

  • EIP versioning:
    • Generally in favor of changelog stopgap solution to version EIPs and check their versions in testing
    • EIPIP also in favor, possibly a preamble entry in the future.
  • feature-forks:
    • Testing team shows off support in EEST for feature-forks (CancunEIP7692 for example) to fill&release only tests related to a feature (EOF in this case)

@poojaranjan
Copy link
Contributor Author

EIP-7577: Versioning Scheme for EIPs was also discussed in the following EIPIP meeting today.

The proposal is merged as Draft however a few editors had concerns related to the adoption of the EIP.

Adding comments to proposal discussion will be helpful to move the proposal to the next status.

@poojaranjan
Copy link
Contributor Author

Closing in favor of #1063

@Parasos
Copy link

Parasos commented Jun 27, 2024

bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants