remove the random state test using BLOCKHASH
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the only state test which uses the `BLOCKHASH` instruction.
This is a random test which actually fails because of the stack
underflow so the result of the `BLOCKHASH` instruction doesn't affect
the post state at all. Any other test for `BLOCKHASH` has been
converted to the blockchain test format where the block hashes are
properly defined.
This is the disassembled code of the test. It fails at DUP11 because of
the stack underflow.
```
// Inputs[5]
// {
// @0063 block.blockHash(0x0000000000000000000000000000000000000000000000000000000000000000)
// @0085 msg.data[0x01:0x21]
// @00A8 stack[-7]
// @00A9 stack[-11]
// @00af memory[0x00:0x20]
// }
0000 7F PUSH32 0x000000000000000000000000000000000000000000000000000000000000c350
0021 7F PUSH32 0x0000000000000000000000000000000000000000000000000000000000000001
0042 7F PUSH32 0x0000000000000000000000000000000000000000000000000000000000000000
0063 40 BLOCKHASH
0064 7F PUSH32 0x0000000000000000000000000000000000000000000000000000000000000001
0085 35 CALLDATALOAD
0086 7F PUSH32 0x0000000000000000000000000000000000000000000000000000000000000001
00A7 0B SIGNEXTEND
00A8 8A DUP11
00A9 9E SWAP15
00AA 12 SLT
00AB 01 ADD
00AC 05 SDIV
00AD 60 PUSH1 0x00
00AF 51 MLOAD
00B0 55 SSTORE
// Stack delta = +1
// Outputs[3]
// {
// @0000 stack[0] = 0x000000000000000000000000000000000000000000000000000000000000c350
// @00A9 stack[-11] = stack[-7]
// @00b0 storage[memory[0x00:0x20]] = ((stack[-11] i< signextend(0x0000000000000000000000000000000000000000000000000000000000000001, msg.data[0x01:0x21])) + block.blockHash(0x0000000000000000000000000000000000000000000000000000000000000000)) i/ 0x0000000000000000000000000000000000000000000000000000000000000001
// }
```
chfast
changed the title
BLOCKHASHBLOCKHASH
|
This test is already present in the blockchain test format: https://github.com/ethereum/legacytests/blob/master/Constantinople/GeneralStateTests/stRandom/randomStatetest101.json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the only state test which uses the
BLOCKHASHinstruction. This is a random test which actually fails because of the stack underflow so the result of theBLOCKHASHinstruction doesn't affect the post state at all. Any other test forBLOCKHASHhas been converted to the blockchain test format where the block hashes are properly defined.This is the disassembled code of the test. It fails at DUP11 because of the stack underflow.