clients/teku: Subscribe to all subnets#653
Merged
holiman merged 1 commit intoethereum:masterfrom Nov 16, 2022
Merged
Conversation
holiman
approved these changes
Nov 16, 2022
alexshliu
pushed a commit
to taikoxyz/hive_old
that referenced
this pull request
Dec 11, 2022
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
Address ethereum#653 Adds 0-padding and indexes at 1 for vc_count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's a common issue for all CL clients. It's expected by the spec that we have a lot of aggregators and they don't need to subscribe to any extra topics, so when we have just 2 peers, there is a non-zero chance that the other peer is not subscribed to the all attestation subnets, so when first peer is releasing an attestation, another peer sometimes is not able to produce aggregate from it, because it's not subscribed to the topic of this attestation. I have added flag
--p2p-subscribe-all-subnets-enabledto ensure both peers are listening to the all attestation topics.