Skip to content

simulators/ethereum/engine: fix Invalid Number NewPayload (Syncing) #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjl merged 1 commit into from
Jun 1, 2022
Merged

simulators/ethereum/engine: fix Invalid Number NewPayload (Syncing) #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion simulators/ethereum/engine/enginetests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ var (
)

var engineTests = []TestSpec{

// Engine API Negative Test Cases
{
Name: "Invalid Terminal Block in ForkchoiceUpdated",
Expand Down Expand Up @@ -985,6 +984,10 @@ func invalidPayloadTestCaseGen(payloadField InvalidPayloadField, syncing bool, e
// it is assumed that the block is missing and we need to sync.
// ACCEPTED also valid since the CLs normally use these interchangeably
q.ExpectStatusEither(Syncing, Accepted)
} else if payloadField == InvalidNumber {
// A payload with an invalid number can force us to start a sync cycle
// as we don't know if that block might be a valid future block.
q.ExpectStatusEither(Invalid, Syncing)
} else {
// Otherwise the response should be INVALID.
q.ExpectStatus(Invalid)
Expand Down