Skip to content

fix(discv5): resolve eth1 ENR via admin_nodeInfo#1456

Closed
emmajam wants to merge 1 commit into
ethereum:masterfrom
emmajam:ejh/admin-nodeinfo-enr-fetch
Closed

fix(discv5): resolve eth1 ENR via admin_nodeInfo#1456
emmajam wants to merge 1 commit into
ethereum:masterfrom
emmajam:ejh/admin-nodeinfo-enr-fetch

Conversation

@emmajam
Copy link
Copy Markdown
Contributor

@emmajam emmajam commented Apr 28, 2026

The eth1 discv5 suite passed the enode URL to devp2p discv5 test,
but enode URLs only describe the discv4/RLPx endpoint. Clients that
bind discv5 to a different UDP port (reth defaults to :9200) were
unreachable, causing all eth1 discv5 tests to time out.

Fetch the signed ENR via admin_nodeInfo, mirroring the pattern already
used for the beacon and portal roles. The ENR's udp/udp6 keys are the
canonical source of the discv5 endpoint. All EL client manifests in
hive already enable admin RPC and ship enode.sh scripts that use
admin_nodeInfo, so this is safe across clients.

@emmajam
Copy link
Copy Markdown
Contributor Author

emmajam commented Apr 28, 2026

also fixing in reth here: paradigmxyz/reth#23613

@cskiraly
Copy link
Copy Markdown
Contributor

I see two issues with this:

  • it is still not working for me, even if using this PR
  • we need to port to be parsable from the enode URL
    We can keep this here to see if discv5 comms works, but this is not the long term solution, so we should not merge.

@emmajam emmajam closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants