fix(discv5): resolve eth1 ENR via admin_nodeInfo#1456
Closed
emmajam wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
also fixing in reth here: paradigmxyz/reth#23613 |
Contributor
|
I see two issues with this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eth1 discv5 suite passed the enode URL to
devp2p discv5 test,but enode URLs only describe the discv4/RLPx endpoint. Clients that
bind discv5 to a different UDP port (reth defaults to :9200) were
unreachable, causing all eth1 discv5 tests to time out.
Fetch the signed ENR via admin_nodeInfo, mirroring the pattern already
used for the beacon and portal roles. The ENR's udp/udp6 keys are the
canonical source of the discv5 endpoint. All EL client manifests in
hive already enable admin RPC and ship enode.sh scripts that use
admin_nodeInfo, so this is safe across clients.