Skip to content

Conversation

@morph-dev
Copy link
Contributor

@morph-dev morph-dev commented Aug 15, 2024

Problem

Currently, the hivesim-rs allows only specific type as a TestData. This is limiting in many ways:

  • Many of the current simulations don't use any test data
  • TestData only contains String objects, which require simulations to serialize/deserialize objects unnecessary
  • Some simulations need exactly one content key-value pair, but they are using Vec because that's how it's defined
  • When simulations need new specific type, they would first need to update hivesim-rs in one PR, in order to use that commit as dependency in their own PR.

Solution

Make test data generic. This removes all above problems without any downsides (in my opinion).
Example of how portal simulators would be updated can be seen here: 3cd8c95 (see #1151)

Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KolbyML KolbyML merged commit 81fc9a3 into ethereum:master Aug 15, 2024
@morph-dev morph-dev deleted the hivesim branch August 15, 2024 19:53
fedacking pushed a commit to lambdaclass/hive that referenced this pull request May 19, 2025
fedacking pushed a commit to lambdaclass/hive that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants