hivesim-rs: allow test data to be generic #1150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the
hivesim-rsallows only specific type as aTestData. This is limiting in many ways:TestDataonly containsStringobjects, which require simulations to serialize/deserialize objects unnecessaryVecbecause that's how it's definedhivesim-rsin one PR, in order to use that commit as dependency in their own PR.Solution
Make test data generic. This removes all above problems without any downsides (in my opinion).
Example of how portal simulators would be updated can be seen here: 3cd8c95 (see #1151)