Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/hiveview: Update max entries on hiveview #1074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spencer-tb
Copy link
Contributor

Currently the hiveview public CI only displays up to 200 entries.

In some cases this means we only display logs for the past 3-4 days, even though we have logs for many more.

I updated this manually within https://hivetests.ethdevops.io/ and note it now stores more than 200 entries.

This is a quick hack, we could alternatively set this value as a cmd line option when serving or deploying ./hiveview.

@fjl
Copy link
Collaborator

fjl commented Apr 4, 2024

The reason why this limit exists is because we want to limit the summary file size for quick load. If we index all runs, it takes a lot longer to load initially.

There are a couple possible fixes. One would be creating a separate file for the full index, and then loading that asynchronously. Or we could change the UI to parse the file and update the display while it is loading, to reduce the initial display latency.

@spencer-tb
Copy link
Contributor Author

This makes sense thanks. I'll look into the first option you mention next week:

One would be creating a separate file for the full index, and then loading that asynchronously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants