Add support for recording SHA3 preimages#3543
Conversation
|
@Arachnid, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obscuren, @jimenezrick and @karalabe to be potential reviewers. |
There was a problem hiding this comment.
naming suggestion: "PreimageTable" (without Get prefix)
There was a problem hiding this comment.
The new operation should be called debug_preimage
There was a problem hiding this comment.
Please write preimages as part of the state commit.
There was a problem hiding this comment.
Doing this introduces an import cycle - state imports core (for database_util), which imports state. This could be solved by removing all the preimage stuff from database_util, but reducing duplication in the number of places where we specify table prefixes etc seems like a Good Thing. Thoughts?
There was a problem hiding this comment.
You don't need this method if you write them during Commit here.
There was a problem hiding this comment.
Please document this. It should say that the method is used for recording preimages seen by the VM.
Arachnid
force-pushed
the
preimage
branch
3 times, most recently
from
6d122cf to
08c1213
Compare
There was a problem hiding this comment.
This needs to be renamed to Preimage
There was a problem hiding this comment.
Please call it preimage in JS to reduce confusion.
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
|
After running some stats on a full-synced node, there are about 2M EVM sha3 preimages, with ~370MB of values (plus ~40 bytes per key, plus overhead). Given the low-ish volume, I'm thinking it probably makes sense to dump the flag and just record these unconditionally like we do for trie preimages. For context, there are 21M trie preimages, totalling ~446M of values. Thoughts? |
There was a problem hiding this comment.
This one and ForceJit may be deleted.
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
There was a problem hiding this comment.
Please document this function
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
|
Please rebase on master to remove the ethdb commit. |
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
|
@Arachnid tests are broken |
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
* fix: fix nodereal builder address * fix: fix puissant builder address * fix: fix comment
6 participants
No description provided.