Skip to content

all: clean up lint issues, remove more dead code#3525

Merged
karalabe merged 3 commits into
ethereum:masterfrom
fjl:all-gosimple-cleanup
Jan 6, 2017
Merged

all: clean up lint issues, remove more dead code#3525
karalabe merged 3 commits into
ethereum:masterfrom
fjl:all-gosimple-cleanup

Conversation

@fjl
Copy link
Copy Markdown
Contributor

@fjl fjl commented Jan 6, 2017

The "delete dead code" commit fixes #2377

@mention-bot
Copy link
Copy Markdown

@fjl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tgerring, @zelig and @obscuren to be potential reviewers.

@fjl fjl added the in progress label Jan 6, 2017
@fjl fjl force-pushed the all-gosimple-cleanup branch 2 times, most recently from 59d783f to f70ccce Compare January 6, 2017 16:18
@fjl fjl removed the in progress label Jan 6, 2017
Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this format change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already reverted ;)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted yes, but the formatting got broken in the revertal.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl force-pushed the all-gosimple-cleanup branch from 307ff7b to 13e3b2f Compare January 6, 2017 17:18
@fjl fjl added this to the 1.5.6 milestone Jan 6, 2017
@karalabe karalabe merged commit ac93a6f into ethereum:master Jan 6, 2017
@ferhatelmas
Copy link
Copy Markdown
Contributor

@fjl @karalabe should we enable gosimple on CI. Right now I checked, there is no reported issue so very small diff.

@fjl
Copy link
Copy Markdown
Contributor Author

fjl commented Dec 1, 2017

@ferhatelmas yes please! gosimple is awesome!

@ferhatelmas
Copy link
Copy Markdown
Contributor

@fjl #15593 thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logger: kill it with ...

4 participants