Skip to content

accounts/abi: fix unittest code#34740

Merged
jwasinger merged 1 commit into
ethereum:masterfrom
cuiweixie:account-ut
May 12, 2026
Merged

accounts/abi: fix unittest code#34740
jwasinger merged 1 commit into
ethereum:masterfrom
cuiweixie:account-ut

Conversation

@cuiweixie
Copy link
Copy Markdown
Contributor

@cuiweixie cuiweixie commented Apr 16, 2026 •
edited
Loading

  1. should use !reflect.DeepEqual.
  2. big.NewInt(0).SetBits([]big.Word{}) work around for DeepEqual when big.Int is zero, unpack return a []big.Word{}.

jwasinger
jwasinger reviewed Apr 16, 2026
View reviewed changes
Comment thread accounts/abi/unpack_test.go
@jwasinger jwasinger merged commit 6af374e into ethereum:master May 12, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwasinger jwasinger jwasinger approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden is a code owner

Assignees

@jwasinger jwasinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cuiweixie @jwasinger