eth/catalyst: wire up slotnum for testing_buildBlockV1#34721
Merged
Conversation
fselmo
requested review from
MariusVanDerWijden,
fjl,
jwasinger and
lightclient
as code owners
fselmo
changed the title
testing_buildBlockV1testing_buildBlockV1
jwasinger
pushed a commit
that referenced
this pull request
Apr 14, 2026
… `testing_buildBlockV1` (#34722) This is a copy of #34721 but against `master` (rather than `bal-devnet-3`), as requested by @jwasinger, since the slotnum logic now exists on `master` as well.
jwasinger
approved these changes
Apr 14, 2026
Contributor
jwasinger
left a comment
jwasinger
left a comment
There was a problem hiding this comment.
I merged it into master, but I'm also going to merge this for convenience because otherwise we would have to do a full rebase to get it into the devnet branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up slotnum for
testing_buildBlockV1forbal-devnet-3branchWe are experimenting testing block building through hive via EELS (PR here). This is the only change needed to test against
bal-devnet-3- missing slotnum.