cmd/keeper, core, eth/catalyst: add block validation in keeper#34087
Draft
gballet wants to merge 7 commits into
Draft
cmd/keeper, core, eth/catalyst: add block validation in keeper#34087gballet wants to merge 7 commits into
gballet wants to merge 7 commits into
Conversation
gballet
changed the title
gballet
force-pushed
the
kw/stateless-modifications
branch
from
300adbb to
f7ed82b
Compare
rjl493456442
reviewed
Apr 1, 2026
| return common.Hash{}, common.Hash{}, err | ||
| } | ||
| if err = validator.ValidateState(block, db, res, true); err != nil { | ||
| if err = validator.ValidateState(block, db, res, validateHeader); err != nil { |
Member
There was a problem hiding this comment.
It's incorrect.
In the keeper, we want to validate the header (validateHeader = true) and also we want to verify various of hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of #34007 because I couldn't directly push to the source branch.
The changes are preserving the cross-validation, which makes sense as this is to be used in DVT and as a validation step vefore launching a prover.
The initial goals have been preserved as much as possible:
ExecuteStateless