core/vm: pull in changes from 33648#33991
Closed
jwasinger wants to merge 19 commits into
Closed
Conversation
Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com> Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>
Co-authored-by: jeevan-sid <g1siddharthr@gmail.com>
CopyHeader copies all pointer-typed header fields (WithdrawalsHash, RequestsHash, SlotNumber, etc.) but was missing the deep copy for BlockAccessListHash added by EIP-7928. This caused the BAL hash to be silently shared between the original and the copy, leading to potential data races and incorrect nil-checks on copied headers.
MariusVanDerWijden
force-pushed
the
bal-devnet-3
branch
from
a247ae0 to
e1521be
Compare
MariusVanDerWijden
requested review from
fjl,
gballet,
lightclient,
s1na and
zsfelfoldi
as code owners
jwasinger
force-pushed
the
bal-devnet-3-callgasrework
branch
2 times, most recently
from
1705858 to
6caeefe
Compare
Contributor
Author
|
Down to one new failing test here. |
The slotNumber field was being passed as a raw *uint64 to the JSON marshaler, which serializes it as a plain decimal integer (e.g. 159). All Ethereum JSON-RPC quantity fields must be hex-encoded per spec. Wrap with hexutil.Uint64 to match the encoding of other numeric header fields like blobGasUsed and excessBlobGas.
…3994) Adds support for returning `blockAccessListHash` in the RPC block header response. This change includes `blockAccessListHash` in `RPCMarshalHeader` when `head.BlockAccessListHash` is not nil, aligning the RPC output with the Header struct which already contains this field.
Contributor
Author
|
Tests passing here now. |
* add method on StateReaderTracker to clear the accumulated reads * don't factor the BAL size into the payload size during construction in the miner * simplify miner code for constructing payloads-with-BALs via the use of aformentioned StateReaderTracker clear method * clean up the configuration of the BAL execution mode based on the preset flag specified
jwasinger
force-pushed
the
bal-devnet-3-callgasrework
branch
from
f442c78 to
97f6e50
Compare
jwasinger
force-pushed
the
bal-devnet-3-callgasrework
branch
from
97f6e50 to
7c9c685
Compare
jwasinger
force-pushed
the
bal-devnet-3-callgasrework
branch
from
7c9c685 to
97d643a
Compare
MariusVanDerWijden
force-pushed
the
bal-devnet-3
branch
from
e5d453c to
b3113ba
Compare
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iteration of these changes in the
bal-devnet-3branch grew stale, and #33648 is the refactored version of the changes.Still failing some tests here that aren't failing on
bal-devnet-3.