core/vm: split stateless and stateful gas costs#33987
Closed
MariusVanDerWijden wants to merge 2 commits into
Closed
core/vm: split stateless and stateful gas costs#33987MariusVanDerWijden wants to merge 2 commits into
MariusVanDerWijden wants to merge 2 commits into
Conversation
Member
|
Btw, there is another open PR for the "same" purpose? I guess yours contains more changes. |
Contributor
|
Yeah, I think #33648 covers the same purpose as these changes: making the call gas handling logic comply with 7928 wrt the order in which the state lookup happens as part of the checks. Looks like 33648 was itself refactored a while ago and those changes didn't get ported to the devnet changes. Let me double check what the exact differences are between this PR and the other branch, and then open a PR to port the changes of the other branch into devnet 3. |
Member
|
closing in favor of #33648 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls out a change necessary for BALs that makes rebasing the 8037 changes painful.
Merging this into master makes it easier to build more stuff on top.
Co-authored-by: Jared Wasinger j-wasinger@hotmail.com