core, core/vm: Rename selfdestruct log to burn#33851
Merged
jwasinger merged 1 commit intoFeb 16, 2026
Merged
Conversation
raxhvl
requested review from
fjl,
gballet,
rjl493456442 and
zsfelfoldi
as code owners
Contributor
|
@raxhvl read the contributor guidelines |
jwasinger
approved these changes
Feb 16, 2026
raxhvl
changed the title
|
@tellabg I return enlightened after studying the sacred text |
3 tasks
Contributor
|
I merged this but it was a mistake: this is a consensus-breaking change that can only go in next devnet. |
Member
Author
|
My bad. What is the correct target branch for such a change? FYI: Nethermind merged it into |
Contributor
|
There's not a branch for devnet 3 yet. |
Contributor
Well this change wasn't spec'd for the current devnet so those clients shouldn't have merged/activated it. |
Member
|
I think nethermind also made a mistake by merging it in. I'd create a new branch bal-devnet-3, and start merging prs like these in there. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethereum/EIPs#11311 renamed the "Selfdestruct" log topic to "Burn" in the EIP-7708 specification.
The rationale is that "Burn" better describes what happens (ETH is destroyed) rather than how it happens (via the SELFDESTRUCT opcode). This creates a more consistent API, which reflects the outcome, not the mechanism.