accounts, internal, trie, triedb: fix test files format#33846
Closed
gzliudan wants to merge 1 commit into
Closed
Conversation
gzliudan
requested review from
MariusVanDerWijden,
fjl,
gballet,
lightclient,
rjl493456442 and
s1na
as code owners
gzliudan
changed the title
Contributor
|
This should be caught by the linter. |
Member
|
We decided not to merge this. We don't run gofmt regularly, so it doesn't make sense to merge this now without changes to our linter as well |
Contributor
|
Just for added context: our CI uses golangci-lint as configured in https://github.com/ethereum/go-ethereum/blob/master/.golangci.yml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run
make fmt