core: fixed unwinding bad hash#3347
Merged
obscuren merged 1 commit intoethereum:masterfrom Nov 28, 2016
Merged
Conversation
|
@obscuren, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zsfelfoldi, @karalabe and @fjl to be potential reviewers. |
obscuren
force-pushed
the
unwind-fix
branch
3 times, most recently
from
7ee324e to
52d3a36
Compare
karalabe
reviewed
Nov 28, 2016
Member
There was a problem hiding this comment.
This check should be either of:
if headerByNumber != nil && headerByNumber.Hash() == header.Hash() { rewind }if headerByNumber == nil || headerByNumber.Hash() != header.Hash() { continue } rewind
Although in theory the current implementation should also work, the conditions are imho not the cleanest combo :)
Fixed unwinding of bad hashes when already on the canon chain
karalabe
approved these changes
Nov 28, 2016
zzzckck
added a commit
to zzzckck/go-ethereum
that referenced
this pull request
Sep 10, 2025
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed unwinding of bad hashes when already on the canon chain