Skip to content

eth/filters: further optimize tx hash map in #32965#33108

Merged
rjl493456442 merged 1 commit intoethereum:masterfrom
MonkeyMarcel:after32965
Nov 13, 2025
Merged

eth/filters: further optimize tx hash map in #32965#33108
rjl493456442 merged 1 commit intoethereum:masterfrom
MonkeyMarcel:after32965

Conversation

@MonkeyMarcel
Copy link
Copy Markdown
Contributor

Follow-up to #32965.

The previous PR avoided rebuilding hash maps multiple times, but we can optimize further:

  • Use struct{} instead of bool as map value (saves 1 byte per entry)
  • Pre-allocate map capacity to avoid rehashing during construction

@rjl493456442 rjl493456442 added this to the 1.16.8 milestone Nov 13, 2025
@rjl493456442 rjl493456442 merged commit 48d708a into ethereum:master Nov 13, 2025
6 of 8 checks passed
atkinsonholly pushed a commit to atkinsonholly/ephemery-geth that referenced this pull request Nov 24, 2025
prestoalvarez pushed a commit to prestoalvarez/go-ethereum that referenced this pull request Nov 27, 2025
fjl pushed a commit to lightclient/go-ethereum that referenced this pull request Nov 28, 2025
weiihann pushed a commit to weiihann/go-ethereum that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants