cmd/utils: allow --networkid to override other config options#32999
Merged
fjl merged 4 commits intoethereum:masterfrom Nov 28, 2025
Merged
cmd/utils: allow --networkid to override other config options#32999fjl merged 4 commits intoethereum:masterfrom
fjl merged 4 commits intoethereum:masterfrom
Conversation
fjl
changed the title
fjl
previously approved these changes
Nov 28, 2025
fjl
previously approved these changes
Nov 28, 2025
fjl
requested review from
MariusVanDerWijden,
gballet,
jwasinger,
rjl493456442,
s1na and
zsfelfoldi
as code owners
fjl
force-pushed
the
cmd-utils-allow-networkid-override
branch
from
34b21d6 to
7fb54af
Compare
fjl
approved these changes
Nov 28, 2025
weiihann
pushed a commit
to weiihann/go-ethereum
that referenced
this pull request
Jan 14, 2026
…um#32999) Recently in ethereum#31630 we removed support for overriding the network id in preset networks. While this feature is niche, it is useful for shadow forks. This PR proposes we add the functionality back, but in a simpler way. Instead of checking whether the flag is set in each branch of the network switch statement, simply apply the network flag after the switch statement is complete. This retains the following behavior: 1. Auto network id based on chain id still works, because `IsSet` only returns true if the flag is _actually_ set. Not if it just has a default set. 2. The preset networks will set their network id directly and only if the network id flag is set is it overridden. This, combined with the override genesis flag is what allows the shadow forks. 3. Setting the network id to the same network id that the preset _would have_ set causes no issues and simply emits the `WARN` that the flag is being set explicitly. I don't think people explicitly set the network id flag often. ``` WARN [10-22|09:36:15.052] Setting network id with flag id=10 ``` --------- Co-authored-by: Felix Lange <fjl@twurst.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently in #31630 we removed support for overriding the network id in preset networks. While this feature is niche, it is useful for shadow forks. This PR proposes we add the functionality back, but in a simpler way.
Instead of checking whether the flag is set in each branch of the network switch statement, simply apply the network flag after the switch statement is complete. This retains the following behavior:
IsSetonly returns true if the flag is actually set. Not if it just has a default set.WARNthat the flag is being set explicitly. I don't think people explicitly set the network id flag often.