consensus/misc/eip4844, internal/ethapi: decouple BPO forks from named forks#32908
Closed
jwasinger wants to merge 3 commits intoethereum:masterfrom
Closed
consensus/misc/eip4844, internal/ethapi: decouple BPO forks from named forks#32908jwasinger wants to merge 3 commits intoethereum:masterfrom
jwasinger wants to merge 3 commits intoethereum:masterfrom
Conversation
jwasinger
requested review from
fjl,
gballet,
lightclient,
rjl493456442,
s1na and
zsfelfoldi
as code owners
Contributor
Author
|
I need to tweak the banner to indicate that BPOs and named forks are decoupled. |
MariusVanDerWijden
force-pushed
the
decouple-bpo
branch
from
b4c4b30 to
be9ec6d
Compare
MariusVanDerWijden
force-pushed
the
decouple-bpo
branch
from
be9ec6d to
e63ce97
Compare
Member
|
Last I heard on this is that we preferred to explicitly define the blob parameters for each fork. Just want to confirm that are changing stance on that? |
Member
|
Marius gave me his blessing |
Member
|
I'm still not happy, but I don't want to stand in the way of progress |
fjl
reviewed
Dec 2, 2025
Contributor
|
I would prefer to take care of this in the config2 refactoring #32224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly, I'm opening this right now so it's known that someone's started working on this. It doesn't seem like this should be a complex change in the end, but I'm still wrapping my head around what's needed.
As I understand it, the end result of these changes will be the following:
Probably, this has implications with config validation, including the validation of fork ordering, and I'm still looking into that aspect of the changes.