fix: websocket test and separate cross platform bug#32892
Closed
mishraa-G wants to merge 2 commits intoethereum:masterfrom
Closed
fix: websocket test and separate cross platform bug#32892mishraa-G wants to merge 2 commits intoethereum:masterfrom
mishraa-G wants to merge 2 commits intoethereum:masterfrom
Conversation
added 2 commits
October 12, 2025 19:06
…and triedb:pathdb:cross-platformbug
ngamesuu-cpu
approved these changes
Oct 12, 2025
Member
|
Fixed by #32899 Thanks for reporting it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Tolerate "connection reset by peer" in TestServerWebsocketReadLimit
What does this PR do?
This PR updates the
TestServerWebsocketReadLimittest to tolerate the"connection reset by peer"error as a valid outcome when the websocket read limit is exceeded.This error can occur due to a race condition where the TCP connection closes before the websocket close frame is sent, as discussed in issue #32866.
Why is this needed?
Occasionally, in CI or some local environments, the test fails with:
Previously, the test only accepted specific websocket errors (like CloseError code 1009, ErrReadLimit, or errors containing "1009"/"message too big").
By allowing "connection reset by peer", the test becomes more robust against this race condition and prevents intermittent failures.
Reference
Fixes #32866
Checklist
Let me know if you want to edit or clarify anything!