Skip to content

accounts/abi/bind: fix data race in TestWaitDeployedCornerCases#32740

Merged
lightclient merged 2 commits intoethereum:masterfrom
hero5512:fix-data-race
Sep 25, 2025
Merged

accounts/abi/bind: fix data race in TestWaitDeployedCornerCases#32740
lightclient merged 2 commits intoethereum:masterfrom
hero5512:fix-data-race

Conversation

@hero5512
Copy link
Copy Markdown
Contributor

@hero5512 hero5512 commented Sep 25, 2025

There is a panic during running

func TestWaitDeployedCornerCases(t *testing.T) {
testcase. The panic occurred when backend.Close() cleared the client while the goroutine was still accessing it. Add channel synchronization to prevent race condition between goroutine calling WaitDeployed and test cleanup closing the backend. https://github.com/ethereum/go-ethereum/actions/runs/17988623261/job/51173400284?pr=32739

Co-authored-by: allen <lvshuaino@gmail.com>
Co-authored-by: lightclient <lightclient@protonmail.com>
lightclient
lightclient previously approved these changes Sep 25, 2025
@lightclient lightclient self-assigned this Sep 25, 2025
@lightclient lightclient merged commit 7611f35 into ethereum:master Sep 25, 2025
5 of 6 checks passed
Sahil-4555 pushed a commit to Sahil-4555/go-ethereum that referenced this pull request Oct 12, 2025
…reum#32740)

Fixes race in WaitDeploy test where the backend is closed before goroutine using it wraps up.

---------

Co-authored-by: lightclient <lightclient@protonmail.com>
atkinsonholly pushed a commit to atkinsonholly/ephemery-geth that referenced this pull request Nov 24, 2025
…reum#32740)

Fixes race in WaitDeploy test where the backend is closed before goroutine using it wraps up.

---------

Co-authored-by: lightclient <lightclient@protonmail.com>
prestoalvarez pushed a commit to prestoalvarez/go-ethereum that referenced this pull request Nov 27, 2025
…reum#32740)

Fixes race in WaitDeploy test where the backend is closed before goroutine using it wraps up.

---------

Co-authored-by: lightclient <lightclient@protonmail.com>
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants