trie, state: integrate batch update into statedb IntermediateRoot#32464
Draft
jwasinger wants to merge 2 commits into
Draft
trie, state: integrate batch update into statedb IntermediateRoot#32464jwasinger wants to merge 2 commits into
IntermediateRoot#32464jwasinger wants to merge 2 commits into
Conversation
Member
|
Can you measure the performance gain by integrating the batch update? My gut feeling is that it won't be obvious, as we have already prefetched the trie nodes, and no IO should be involved in batch update. |
Contributor
Author
|
Yeah sure. I was also under the impression that this is only useful for BALs because of the prefetcher doing the majority of the useful work (and low rate of wasted prefetcher work, i.e. not many reverts in a block). |
Contributor
Author
|
This PR is a bit slower than master: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not intended for merge: this will be merged into the BAL changes.
iteration on #32448 which integrates the batch update into
IntermediateRoot.