consensus/misc/eip4844: use blob parameters of current header#32424
Merged
fjl merged 4 commits intoethereum:masterfrom Aug 15, 2025
Merged
consensus/misc/eip4844: use blob parameters of current header#32424fjl merged 4 commits intoethereum:masterfrom
fjl merged 4 commits intoethereum:masterfrom
Conversation
This changes the implementation to resolve the blob parameters according to the current header timestamp. This matters for EIP-7918, where we would previously resolve the UpdateFraction according to the parent header fork, leading to a confusing situation at the fork transition block.
lightclient
reviewed
Aug 15, 2025
| var ( | ||
| baseCost = big.NewInt(params.BlobBaseCost) | ||
| reservePrice = baseCost.Mul(baseCost, parent.BaseFee) | ||
| blobPrice = bcfg.blobPrice(excessBlobGas) |
Member
There was a problem hiding this comment.
Suggested change
| blobPrice = bcfg.blobPrice(excessBlobGas) | |
| blobPrice = bcfg.blobPrice(parentExcessBlobGas) |
I believe this was the issue Marius found and fixed here: https://github.com/fjl/go-ethereum/compare/eip4844-transition-updatefraction...MariusVanDerWijden:go-ethereum:eip4844-transition-updatefraction?expand=1
Member
Member
|
Wait I broke something with the submodule edit: okay fixed, I hate git |
MariusVanDerWijden
force-pushed
the
eip4844-transition-updatefraction
branch
from
2d526d2 to
af45e2e
Compare
yzang2019
added a commit
to yzang2019/go-ethereum
that referenced
this pull request
Aug 15, 2025
* master: (57 commits) core/vm: fix EIP-7823 modexp input length check (ethereum#32363) rlp: remove workaround for Value.Bytes (ethereum#32433) consensus/misc/eip4844: use blob parameters of current header (ethereum#32424) crypto/bn256: refactor to use bitutil.TestBytes (ethereum#32435) core/vm: refactor to use bitutil.TestBytes (ethereum#32434) cmd/evm: use PathScheme in blockrunner (ethereum#32444) trie, core/state: add the transition tree (verkle transition part 2) (ethereum#32366) build: remove unused functions (ethereum#32393) crypto/secp256k1: use ReadBits from common/math (ethereum#32430) build: upgrade -dlgo version to Go 1.25.0 (ethereum#32412) .github: upgrade workflows to Go 1.25 (ethereum#32425) p2p: refactor to use time.Now().UnixMilli() in golang std lib (ethereum#32402) eth/syncer: fix typo (ethereum#32427) eth/tracers: Adds codeHash to prestateTracer's response (ethereum#32391) rlp: optimize intsize (ethereum#32421) node: remove unused err var (ethereum#32398) eth: abort `requiredBlocks` check if peer handler terminated (ethereum#32413) cmd: fix inconsistent function name in comment (ethereum#32411) trie: refactor to use slices.Concat (ethereum#32401) consensus: fix ambiguous invalid gas limit error (ethereum#32405) ...
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
…um#32424) This changes the implementation to resolve the blob parameters according to the current header timestamp. This matters for EIP-7918, where we would previously resolve the UpdateFraction according to the parent header fork, leading to a confusing situation at the fork transition block. --------- Co-authored-by: MariusVanDerWijden <m.vanderwijden@live.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the implementation to resolve the blob parameters according to the current header timestamp. This matters for EIP-7918, where we would previously resolve the UpdateFraction according to the parent header fork, leading to a confusing situation at the fork transition block.