Skip to content

core/txpool/blobpool: lower log level for warnings #32142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MariusVanDerWijden merged 2 commits into from
Jul 7, 2025
Merged

core/txpool/blobpool: lower log level for warnings #32142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc0875
fix some carps in blobpool
mask-pp Jul 3, 2025
7bd98d1
fix comment
mask-pp Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/txpool/blobpool/limbo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (l *limbo) finalize(final *types.Header) {
// Just in case there's no final block yet (network not yet merged, weird
// restart, sethead, etc), fail gracefully.
if final == nil {
log.Error("Nil finalized block cannot evict old blobs")
log.Warn("Nil finalized block cannot evict old blobs")
return
}
for block, ids := range l.groups {
Expand All @@ -139,11 +139,11 @@ func (l *limbo) push(tx *types.Transaction, block uint64) error {
// If the blobs are already tracked by the limbo, consider it a programming
// error. There's not much to do against it, but be loud.
if _, ok := l.index[tx.Hash()]; ok {
log.Error("Limbo cannot push already tracked blobs", "tx", tx)
Comment thread
mask-pp marked this conversation as resolved.
log.Error("Limbo cannot push already tracked blobs", "tx", tx.Hash())
return errors.New("already tracked blob transaction")
}
if err := l.setAndIndex(tx, block); err != nil {
log.Error("Failed to set and index limboed blobs", "tx", tx, "err", err)
log.Error("Failed to set and index limboed blobs", "tx", tx.Hash(), "err", err)
return err
}
return nil
Expand Down