Skip to content

eth/downloader: fix downloader cancel#32098

Closed
rjl493456442 wants to merge 1 commit into
ethereum:masterfrom
rjl493456442:fix-downloader-cancel
Closed

eth/downloader: fix downloader cancel#32098
rjl493456442 wants to merge 1 commit into
ethereum:masterfrom
rjl493456442:fix-downloader-cancel

Conversation

@rjl493456442
Copy link
Copy Markdown
Member

This PR reverts the changes brought by #32067

Previously, the chain insertion will always be interrupted once the downloader.Cancel is called.
Unfortunately, the aborted error from Blockchain will be propagated and ultimately leading to
the corresponding peer serving this chain segment being dropped.

Therefore, this PR reverts the behavioral changes and only interrupt the chain insertion when
tearing down Geth. The debug_setHead needs to be improved with better solution.

@rjl493456442
Copy link
Copy Markdown
Member Author

The change is probably not correct. It's true that the aborted error will be bubbled up, but it's discarded by downloading without propagating to the handler.

The disconnection should be relevant with some other reasons.

@rjl493456442
Copy link
Copy Markdown
Member Author

After some investigation, the peer dropping is caused by the skeleton header fetching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants