eth/downloader: fix downloader cancel#32098
Closed
rjl493456442 wants to merge 1 commit into
Closed
Conversation
Member
Author
|
The change is probably not correct. It's true that the The disconnection should be relevant with some other reasons. |
Member
Author
|
After some investigation, the peer dropping is caused by the skeleton header fetching. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes brought by #32067
Previously, the chain insertion will always be interrupted once the
downloader.Cancelis called.Unfortunately, the
abortederror from Blockchain will be propagated and ultimately leading tothe corresponding peer serving this chain segment being dropped.
Therefore, this PR reverts the behavioral changes and only interrupt the chain insertion when
tearing down Geth. The
debug_setHeadneeds to be improved with better solution.