eth/tracers: fix supply tracer uncle accounting#31882
Merged
Merged
Conversation
Contributor
|
Test failling on windows: |
Contributor
|
Also now that you will make changes please rename the tests so they reflect being related to the supply tracer. A side note: the existing test suite is in eth/tracers/internal/tracetest/supply_test.go |
lightclient
force-pushed
the
fix-supply-tracer
branch
from
45eebbd to
d103430
Compare
sjb933
force-pushed
the
fix-supply-tracer
branch
from
d103430 to
54c2d4f
Compare
Contributor
Author
|
@s1na please check the update. I removed my added test file and improved the existing tests. |
Contributor
Author
|
Bump. @s1na please see the last update. It'd be good to merge since this is a fairly obvious bug and the supply-tracer currently undercounts the total supply when running from genesis. |
s1na
changed the title
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
Uncle rewards were being omitted in the supply tracer due to a bug. This PR fixes that. --------- Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug in the supply tracer, it's missing a
fallthroughfor thetracing.BalanceIncreaseRewardMineUnclecase.I added unit tests and fixed the issue 👍