blobpool: fix blob validation rule#31827
Closed
0x00101010 wants to merge 1 commit intoethereum:masterfrom
Closed
Conversation
0x00101010
changed the title
0x00101010
commented
May 14, 2025
| Config: p.chain.Config(), | ||
| Accept: 1 << types.BlobTxType, | ||
| MaxSize: txMaxSize, | ||
| MaxSize: txMaxSize + uint64(eip4844.LatestMaxBlobsPerBlock(p.chain.Config())*blobSize), |
Author
There was a problem hiding this comment.
validation happens here, where tx.Size() does indeed calculate blob sizes
Contributor
|
Fyi relevant issue: #31792. |
Member
|
closing in favor of #31837 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if we try to submit transactions over 7 blobs, we'll get
oversized data: transaction size 1049793, limit 1048576errorThis PR fixes that by taking the blob count into consideration when validating blob transactions