p2p: name dial sources to allow better diagnostics and stats#31588
Closed
cskiraly wants to merge 1 commit into
Closed
p2p: name dial sources to allow better diagnostics and stats#31588cskiraly wants to merge 1 commit into
cskiraly wants to merge 1 commit into
Conversation
cskiraly
requested review from
fjl,
holiman,
rjl493456442 and
zsfelfoldi
as code owners
Adding an optional name to the dial sources allows better diagnostics of FairMix and the whole dial process. Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
cskiraly
force-pushed
the
dialsource-diag
branch
from
dcfa74e to
7f2db0e
Compare
Contributor
|
I have submitted an alternative which also works for tracking the names across nested FairMix instances: #31779 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we add optional names to dial sources. This allows better diagnostics of FairMix and the whole dial process. It also allows better statistics on top (TBD in a follow-up PR).