Skip to content

core/txpool/legacypool: data race in checkDelegationLimit #31475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

core/txpool/legacypool: data race in checkDelegationLimit #31475

merged 3 commits into from
Mar 28, 2025

Conversation

@rekyyang
Copy link
Contributor

@rekyyang rekyyang commented Mar 24, 2025

No description provided.

@rekyyang rekyyang changed the title fix data race in checkDelegationLimit fix: data race in checkDelegationLimit Mar 24, 2025
@rekyyang
Copy link
Contributor Author

rekyyang commented Mar 24, 2025

#31474

@rjl493456442 rjl493456442 self-assigned this Mar 24, 2025
@fjl fjl changed the title fix: data race in checkDelegationLimit core/txpool/legacypoo: data race in checkDelegationLimit Mar 24, 2025
@fjl fjl changed the title core/txpool/legacypoo: data race in checkDelegationLimit core/txpool/legacypool: data race in checkDelegationLimit Mar 24, 2025
@rjl493456442
Copy link
Member

rjl493456442 commented Mar 24, 2025

The data race is theoretically possible but does not occur in practice.

The lookup struct can only be modified by Add and Remove. In legacypool, both functions are always invoked while holding txpool.mu. This ensures that lookup.Add or lookup.Remove cannot be called concurrently with len(pool.all.auths[from]) == 0.

rjl493456442
rjl493456442 previously approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the nitpick.

@rekyyang
Copy link
Contributor Author

rekyyang commented Mar 24, 2025

fixed

@rjl493456442 rjl493456442 added this to the 1.15.7 milestone Mar 25, 2025
@rjl493456442 rjl493456442 merged commit 141968a into ethereum:master Mar 28, 2025
3 of 4 checks passed
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Mar 28, 2025
@rekyyang
core/txpool/legacypool: fix data race in checkDelegationLimit (ethere…
2db399f 
…um#31475)
@sonhv0212 sonhv0212 mentioned this pull request Apr 3, 2025
Merged
sivaratrisrinivas pushed a commit to sivaratrisrinivas/go-ethereum that referenced this pull request Apr 21, 2025
@rekyyang @sivaratrisrinivas
core/txpool/legacypool: fix data race in checkDelegationLimit (ethere…
95429f8 
…um#31475)
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request May 22, 2025
@rekyyang @buddh0
core/txpool/legacypool: fix data race in checkDelegationLimit (ethere…
8708564 
…um#31475)
jakub-freebit pushed a commit to fblch/go-ethereum that referenced this pull request Jul 3, 2025
@rekyyang @jakub-freebit
core/txpool/legacypool: fix data race in checkDelegationLimit (ethere…
c4d4218 
…um#31475)
howjmay pushed a commit to iotaledger/go-ethereum that referenced this pull request Aug 27, 2025
@rekyyang @howjmay
core/txpool/legacypool: fix data race in checkDelegationLimit (ethere…
8e614fe 
…um#31475)
gballet pushed a commit to gballet/go-ethereum that referenced this pull request Sep 11, 2025
@rekyyang @gballet
core/txpool/legacypool: fix data race in checkDelegationLimit (ethere…
540de8e 
…um#31475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@holiman holiman Awaiting requested review from holiman

Assignees

@rjl493456442 rjl493456442

Labels

None yet

Projects

None yet

Milestone

1.15.7

Development

Successfully merging this pull request may close these issues.

2 participants

@rekyyang @rjl493456442