accounts/abi: include access-list in gas estimation#31394
Merged
s1na merged 1 commit intoethereum:masterfrom Mar 26, 2025
Merged
accounts/abi: include access-list in gas estimation#31394s1na merged 1 commit intoethereum:masterfrom
s1na merged 1 commit intoethereum:masterfrom
Conversation
protolambda
requested review from
MariusVanDerWijden and
gballet
as code owners
Contributor
|
We need to apply this on top of #31379 when it's merged. |
jwasinger
previously approved these changes
Mar 15, 2025
Contributor
|
#31379 is now merged. Please rebase. |
jwasinger
dismissed stale reviews from MariusVanDerWijden and themself
via
3080782
jwasinger
force-pushed
the
accesslist-abi
branch
from
1225a38 to
3080782
Compare
jwasinger
approved these changes
Mar 25, 2025
sivaratrisrinivas
pushed a commit
to sivaratrisrinivas/go-ethereum
that referenced
this pull request
Apr 21, 2025
Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
May 22, 2025
Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.
howjmay
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Aug 27, 2025
Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 2, 2025
Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 3, 2025
Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Sep 8, 2025
…1417) Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code. Co-authored-by: protolambda <proto@protolambda.com>
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple bugfix to include the access-list in the gas-estimation step of the ABI bindings code.
With OP-Stack we stumbled on it during testing of a contract that reverts when access-list data is missing.
We fixed it in op-geth here: ethereum-optimism/op-geth#546