cmd/evm: don't reuse state between evm benchmark iterations. ensure benchmark errors are included in output. #30780
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enchmark errors are captured and printed to output.
jwasinger
requested review from
holiman,
MariusVanDerWijden and
lightclient
as code owners
holiman
reviewed
Nov 21, 2024
cmd/evm/runner.go
Outdated
| @@ -82,24 +82,33 @@ type execStats struct { | |||
| GasUsed uint64 `json:"gasUsed"` // the amount of gas used during execution | |||
| } | |||
|
|
|||
| func timedExec(bench bool, execFunc func() ([]byte, uint64, error)) ([]byte, execStats, error) { | |||
| func timedExec(bench bool, execFunc func() ([]byte, uint64, error)) (output []byte, stats execStats, execErr error, benchErr error) { | |||
There was a problem hiding this comment.
Instead of adding more returns... so we wanted to do Fatalf, which essentually stops everything. How about doing a panic instead of returning the benchErr? More or less the same as b.Fatalf?
There was a problem hiding this comment.
I just think it's getting a bit unwieldy, this is supposed to be a neat little helper
There was a problem hiding this comment.
I agree that a panic is fine here: this error case indicates that something is wrong with our implementation.
Co-authored-by: Martin HS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing state between benchmark iterations resulted in inconsistent results across runs, which surfaced in #30778 .
If these errors are triggered again, they should be printed to output. To ensure that the code invoking
testing.Benchmark()can catch and output these errors, and then exit: I replace calls tot.B.Fatalfwith setting an error which is consumed by the calling code.The same consistency checks should probably be applied to the state test benchmarker. I am figuring that out now.
closes #30778 .