all: use t.TempDir() instead of os.TempDir() in tests#30168
Conversation
t.TempDir() instead of os.TempDir() in testt.TempDir() instead of os.TempDir() in test
t.TempDir() instead of os.TempDir() in test|
From @karalabe: In the past many months we have had a lot of issues with people opening PRs that are - for the most part - not useful. These include typo fixes, performance optimisations in non-hot code paths, variable renames, error message tweaks, etc. Whilst these PRs aren't unilaterally bad or worthless, most people are not opening them to make our codebase better, rather they are opening to farm commits for airdrops. From our perspective, these commits often take a non-negligible effort to review and merge, because they keep touching sensitive code, that we need to be extra careful to understand. Even trivial fixes require attention and keep distracting us from focusing on developing and maintaining Geth. We've decided to be more agressive in rejecting outside contributions that do not make a meaningful improvement:
We appreciate the enthusiasm and effort of opening a PR against Geth, but due to the significant abuse against our time, we'll be closing PRs of the above type for the foreseeable future. We apologise if someone's genuine effort gets caught up in this agressive stance. |
Similar to #30150