You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation for this default gas price exists, but is actually unable to be set via a flag, because the flag was not created. This PR simply adds the flag and the context check if its set, and updates cfg.Default if so.
@cyberhorsey what do you think about this: #30080
The default wasn't really used anywhere so we can just get rid of it.
It only really determines the start price of the oracle, so I don't think it needs to be configurable by the user.
Lemme know if I missed something
@cyberhorsey what do you think about this: #30080 The default wasn't really used anywhere so we can just get rid of it. It only really determines the start price of the oracle, so I don't think it needs to be configurable by the user. Lemme know if I missed something
Can be fine as well, we actually use it at Taiko (and added this flag on our fork) when launching our chain and testnets, but we can just keep it on our fork if removing it is better here.
As @MariusVanDerWijden said, the flag only sets the starting price, and that price will start drifting as predictions are made. So configuring it is useless, because the config value doesn't stick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation for this default gas price exists, but is actually unable to be set via a flag, because the flag was not created. This PR simply adds the flag and the context check if its set, and updates
cfg.Defaultif so.