Skip to content

ipv6 address used as extip results in 127.0.0.1 being used #29736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smin-k wants to merge 5 commits into from
Closed

ipv6 address used as extip results in 127.0.0.1 being used #29736

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57164d4
p2p/enode: fix ipv6 address used as extip results in 127.0.0.1 being …
smin-k May 8, 2024
577a52a
p2p/enode: fix ipv6 address used as extip results in 127.0.0.1 being
smin-k May 8, 2024
d35a62e
p2p/enode: fix ipv6 address used as extip results
smin-k May 9, 2024
7b5fceb
ipv6 address used as extip results in 127.0.0.1
smin-k May 9, 2024
f8971af
p2p/enode: remove comment
smin-k May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion p2p/enode/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,20 @@ func (n *Node) IP() net.IP {
ip6 enr.IPv6
)
if n.Load(&ip4) == nil {
return net.IP(ip4)
ipv4Addr := net.IP(ip4)
if !ipv4Addr.IsLoopback() {
return ipv4Addr
}
}
if n.Load(&ip6) == nil {
return net.IP(ip6)
}
if n.Load(&ip4) == nil {
ipv4Addr := net.IP(ip4)
if ipv4Addr.IsLoopback() {
return ipv4Addr
}
}
return nil
}

Expand Down