core/state: update storage objects concurrently to one another#29696
Closed
karalabe wants to merge 1 commit intoethereum:masterfrom
karalabe:concurrent-state-update
Closed
core/state: update storage objects concurrently to one another#29696karalabe wants to merge 1 commit intoethereum:masterfrom karalabe:concurrent-state-update
karalabe wants to merge 1 commit intoethereum:masterfrom
karalabe:concurrent-state-update
Conversation
Member
Author
|
I've ran a bunch of benchmarks. The performance gains are not really relevant enough to warrant with PR going in standalone. There are some more changes in the prefetcher bundled together, but if there's some meaningful gains, they might be due to the prefetcher more, so I'll just incorporate this in that work instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the update counterpart to #29681. The observation here is that storage objects are independent of one another, so they can be updated independently and hashed.
Further, in this specific PR, the advantage of concurrently updating them is that if the contract trie nodes have not been fully prefetched, that the loads from disk can continue concurrently (yay SSD), instead of restricting it to sequential loads like the current code does.
Benchmarks pending.