Skip to content

eth/tracers/native: fix flatCallTracer Stop() bug#29623

Merged
fjl merged 5 commits intoethereum:masterfrom
draganm:fix-flat-call-tracer-stop
Apr 30, 2024
Merged

eth/tracers/native: fix flatCallTracer Stop() bug#29623
fjl merged 5 commits intoethereum:masterfrom
draganm:fix-flat-call-tracer-stop

Conversation

@draganm
Copy link
Copy Markdown
Contributor

@draganm draganm commented Apr 23, 2024

Fix for #29622:

Store reason when Stop is called in the flatCallTracer. This will be returned when GetResult() is called.

@draganm draganm requested a review from s1na as a code owner April 23, 2024 09:20
s1na
s1na approved these changes Apr 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goot catch. Pushed some changes to fix the interrupt signal. LGTM

rjl493456442
rjl493456442 reviewed Apr 23, 2024
View reviewed changes
Comment thread eth/tracers/native/call_flat_test.go
holiman
holiman reviewed Apr 23, 2024
View reviewed changes
Comment thread eth/tracers/native/call_flat.go Outdated
@karalabe karalabe added this to the 1.14.1 milestone Apr 23, 2024
@PlasmaPower PlasmaPower mentioned this pull request Apr 24, 2024
Merged
@s1na
Copy link
Copy Markdown
Contributor

s1na commented Apr 25, 2024

Jotting down result of discussion: we can avoid all the if interrupt.Load() checks if we instead clear the function pointers on Stop. Note this would apply to all other tracers too. This is because EVM already checks for hook != nil and will not invoke those methods.

@fjl fjl merged commit 7c7e3a7 into ethereum:master Apr 30, 2024
@BrewTestBot BrewTestBot mentioned this pull request May 8, 2024
Merged
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
@draganm @s1na @jorgemmsilva
eth/tracers/native: fix flatCallTracer Stop() bug (ethereum#29623)
16ffd05 
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
@Unique-Divine Unique-Divine mentioned this pull request Apr 16, 2025
Merged
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2025
@draganm @s1na @gzliudan
eth/tracers/native: fix flatCallTracer Stop() bug ethereum#29623
778f123 
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
@gzliudan gzliudan mentioned this pull request Sep 10, 2025
Merged
19 tasks
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Sep 13, 2025
@gzliudan @draganm @s1na
eth/tracers/native: fix flatCallTracer Stop() bug ethereum#29623 (#1465)
23e2e20 
Co-authored-by: Dragan Milic <dragan@netice9.com>
Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 rjl493456442 left review comments

@s1na s1na s1na approved these changes

+1 more reviewer

@holiman holiman holiman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.14.2

Development

Successfully merging this pull request may close these issues.

6 participants

@draganm @s1na @holiman @rjl493456442 @fjl @karalabe