cmd/geth, cmd/utils: rename config and flag to VMTraceJsonConfig#29573
Merged
holiman merged 1 commit intoethereum:masterfrom Apr 24, 2024
Merged
cmd/geth, cmd/utils: rename config and flag to VMTraceJsonConfig#29573holiman merged 1 commit intoethereum:masterfrom
VMTraceJsonConfig#29573holiman merged 1 commit intoethereum:masterfrom
Conversation
from VMTraceConfig to VMTraceJsonConfig
ziogaschr
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
changed the title
VMTraceJsonConfig
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
…thereum#29573) renames the yaml config field VMTraceConfig to VMTraceJsonConfig, in order to be consistent with the renaming of the CLI flag.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 12, 2025
19 tasks
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames yaml config field
VMTraceConfigtoVMTraceJsonConfig, in order to be consistent with the renaming of the CLI flag.In response to #29559 (comment), thanks for the nice catch @rjl493456442 and @s1na.